Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix x-forwarded-proto detection #578

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Fix x-forwarded-proto detection #578

merged 1 commit into from
Mar 26, 2018

Conversation

AD7six
Copy link
Contributor

@AD7six AD7six commented Mar 26, 2018 •
edited
Loading

Forwarded-proto detection is currently looking for headers that aren't set - because:

  • HTTP headers have the prefix HTTP_
  • php's env variables are underscored, not hyphenated

Related: #251

stayallive
stayallive approved these changes Mar 26, 2018
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Jean85
Copy link
Collaborator

Jean85 commented Mar 26, 2018

Build failure is unrelated, it will be probably fixed in #576. Merging!

@Jean85 Jean85 merged commit 0988388 into getsentry:master Mar 26, 2018
@Jean85 Jean85 mentioned this pull request May 3, 2018
Merged
27 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

@stayallive stayallive stayallive approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AD7six @Jean85 @stayallive