Fix for exceptions throwing exceptions #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
requested changes
May 1, 2018
stayallive
changed the title
Jean85
approved these changes
May 2, 2018
Jean85
added a commit
that referenced
this pull request
May 4, 2018
Jean85
added a commit
that referenced
this pull request
May 9, 2018
* Fix gzipCompress function name PHP doesn't have `gzipCompress` function, use `gzcompress` instead http://php.net/manual/en/function.gzcompress.php (cherry picked from commit d391712) * Fix notice during tests * Fix Client PHPDoc tag (port of #548 to 2.x) * Added syntax highlighting to README.md (#551) (cherry picked from commit 4dd0a3e) * Add use statement for HttpException class (cherry picked from commit 389c3ac, port of #556 to 2.x) * Change badge with badge poser. (cherry picked from commit 47ce095, port of #557 to 2.x) * Update docs config (cherry picked from commit f9c90cf) * Add test to handle non default port in host (port of #572 to 2.x) * Update changelog with 1.8.4 info (port of #573 to 2.x) * Allow serialization 5 levels deep (port of #554 to 2.x) * Make Serializer string limit customizable (port of #559 to 2.x) * Avoid looping when exception throws exception (port of #587 to 2.x) * Fix monolog handler not accepting Throwable (port of #586 to 2.x) * Fix serializer to account for non-UTF-8 chars (port of #553 to 2.x) * Add 1.9.0 changelog entries (cherry picked from commit 01171cf) * Add timeout and excluded_options config docs (cherry picked from commit 6860a3e) * Add back unrelease heading to changelog (cherry picked from commit 3f52e6f) * Fix CS
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #579.
But not sure if worth it!? If so, needs tests still!