Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support longer creditcard numbers #635

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Support longer creditcard numbers #635

merged 2 commits into from
Aug 1, 2018

Conversation

153957
Copy link
Contributor

@153957 153957 commented Jul 31, 2018

@Jean85
Copy link
Collaborator

Jean85 commented Jul 31, 2018

Hi, and thanks for your contribution!
It seems that you have broken our build... can you fix that? I would also like to port this onto the 2.0 branch...

@153957
Copy link
Contributor Author

153957 commented Jul 31, 2018 •
edited
Loading

I fixed the tests, feel free to port it to the 2.0 branch.
Remaining build errors are not related to the changes in this PR.

@Jean85
Copy link
Collaborator

Jean85 commented Jul 31, 2018

I've restarted the failed jobs, all green! 👍

stayallive
stayallive approved these changes Aug 1, 2018
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@stayallive stayallive merged commit bca6447 into getsentry:master Aug 1, 2018
@153957 153957 deleted the patch-1 branch August 1, 2018 12:57
@Jean85 Jean85 mentioned this pull request Aug 3, 2018
Closed
11 tasks
Jean85 added a commit that referenced this pull request Aug 3, 2018
@Jean85
Support longer creditcard numbers (port #635 manually to 2.0)
0d621c2
@Jean85 Jean85 mentioned this pull request Aug 3, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

@stayallive stayallive stayallive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@153957 @Jean85 @stayallive