Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove unused option mb_detect_order #754

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Remove unused option mb_detect_order #754

merged 1 commit into from
Jan 28, 2019

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Jan 28, 2019

Same as #753

@Jean85 Jean85 added this to the Release 2.0 milestone Jan 28, 2019
@Jean85 Jean85 self-assigned this Jan 28, 2019
@ste93cry
Copy link
Collaborator

You should document the change in the UPGRADE.md file

@Jean85
Copy link
Collaborator Author

Jean85 commented Jan 28, 2019

@ste93cry it's already documented like that: https://github.com/getsentry/sentry-php/blame/master/UPGRADE-2.0.md#L29

@Jean85 Jean85 merged commit 5cfcdfb into master Jan 28, 2019
@Jean85 Jean85 deleted the remove-unused-option branch January 28, 2019 14:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

@stayallive stayallive stayallive approved these changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees

@Jean85 Jean85

Labels
Type: Improvement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Jean85 @ste93cry @stayallive