-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add AppVeyor #758
Add AppVeyor #758
Conversation
AppVeyor is running now. |
Just asking: why there are two tasks for AppVeyor ( |
There are probably 2 builds 1 for the current branch and 1 for the result if the PR was merged (so target branch + pr) I believe. pr:
branch:
|
Mmm, it's fine but now I'm wondering why Travis CI doesn't do the same... |
Possibly turned off. Looks like Travis only checks the "merged pr" branch (which would be fine for appveyor too I think). |
I agree, the build in the branch is superfluous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is green! No longer WIP, please review and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Since #757 didn't work out, this is an attempt to have AppVeyor as a CI for Windows. I've took inspiration from the build that Symfony does: https://github.com/symfony/symfony/blob/master/.appveyor.yml