-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Error handler as singleton and with listeners #762
Conversation
We should not forget to update docs: https://github.com/getsentry/sentry-docs/blob/master/src/collections/_documentation/platforms/php/default-integrations.md |
Otherwise, this PR really looks good, like the approach. I will close my PR :) |
Can you please also add an entry to the |
Was just about to complain that I'm not sure this PR also fixes that but I'll check it out when I find the time. Either way this is a nice improvement 👍 |
We completely changed the approach there, splitting in two separate listeners, so that should be fixed! |
It's not, @RobinHoutevelts is right in saying that we're still calling the |
But that's no longer a problem, because we're no longer invoking the I broke that (not ideal) chain with this PR. |
You're right, sorry for the mistake then |
Sorry for opening a new PR, but this is a new approach to solve #746, different from #759.
In here, as discussed together, we use the integrations to attach two listeners to the error handler, moving away the issue of error level filtering from that class.
I like this approach very much: