Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes #761 #763

Merged
merged 6 commits into from
Feb 4, 2019
Merged

Fixes #761 #763

merged 6 commits into from
Feb 4, 2019

Conversation

sztyup
Copy link
Contributor

@sztyup sztyup commented Feb 4, 2019

No description provided.

stayallive
stayallive requested changes Feb 4, 2019
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a nitpicky thing about isset and empty, thanks 👍

src/Stacktrace.php Outdated Show resolved Hide resolved
@stayallive @sztyup
Simplification
aa854d6 
Co-Authored-By: sztyup <sztyup@users.noreply.github.com>
ste93cry
ste93cry requested changes Feb 4, 2019
View reviewed changes
src/Stacktrace.php Show resolved Hide resolved
tests/StacktraceTest.php Outdated Show resolved Hide resolved
tests/StacktraceTest.php Show resolved Hide resolved
Jean85
Jean85 approved these changes Feb 4, 2019
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ste93cry remarks are good but I think here we can pay a trade off for better performance.

@ste93cry ste93cry added this to the Release 2.0 milestone Feb 4, 2019
@ste93cry ste93cry merged commit aa444b7 into getsentry:master Feb 4, 2019
@ste93cry ste93cry mentioned this pull request Feb 4, 2019
Closed
@sztyup sztyup mentioned this pull request May 16, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

@ste93cry ste93cry ste93cry approved these changes

@stayallive stayallive stayallive approved these changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sztyup @stayallive @ste93cry @Jean85