Use mb_* functions to handle serialization and unicode file paths #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r unicode file paths
Jean85
approved these changes
Feb 20, 2019
HazAT
approved these changes
Feb 20, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #727 by using
mb_*functions whenever possible. This is especially important while serializing the stacktrace and the frame arguments because if not encoded in UTF-8 the JSON serialization will fail. Also, Sentry server expects the data to be in that encoding anyway. I've also removed some conditional checks that verified if thembstringextension was available since it's a requirement in thecomposer.json