Support HTTPlug 2 / PSR-18 #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ste93cry
requested changes
Feb 23, 2019
HazAT
requested changes
Feb 25, 2019
src/ClientBuilder.php
Outdated
| CURLOPT_PROXY => $this->options->getHttpProxy(), | ||
| ]); | ||
| } else { | ||
| if (class_exists(HttpCurlClient::class)) { |
There was a problem hiding this comment.
Shouldn't this be ! 🤔 ?
Suggested change
| if (class_exists(HttpCurlClient::class)) { | |
| if (!class_exists(HttpCurlClient::class)) { |
HazAT
approved these changes
Feb 25, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I allow the usage of HTTPlug 2, that is PSR-18 compatible.
Unfortunately, the Curl client that uses HTTPlug 2 will be a new major (2.0), which hasn't released yet, so I've added a dedicated CI job to test it explicitly, replacing it with the Guzzle adapter.