Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Suggest monolog #916

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Suggest monolog #916

merged 1 commit into from
Nov 1, 2019

Conversation

TheLevti
Copy link
Contributor

@TheLevti TheLevti commented Nov 1, 2019 •
edited
Loading

  • Suggest installing monolog to send log messages directly to sentry.

Closes #908

@TheLevti TheLevti changed the title getsentry/sentry-php#908: Suggest monolog #908: Suggest monolog Nov 1, 2019
@TheLevti TheLevti changed the title #908: Suggest monolog Suggest monolog Nov 1, 2019
ste93cry
ste93cry requested changes Nov 1, 2019
View reviewed changes
Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small changes, then LGTM. Can you also squash the two commits please?

CHANGELOG.md Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@ste93cry ste93cry added this to the 2.2 milestone Nov 1, 2019
@TheLevti
Copy link
Contributor Author

TheLevti commented Nov 1, 2019 •
edited
Loading

Will do the squash a bit later as I have to leave for some time.

@TheLevti
#908: Suggest installing monolog
d9b0973 
- Suggest installing monolog to send log messages directly to sentry.
@TheLevti
Copy link
Contributor Author

TheLevti commented Nov 1, 2019

Squashed the commits.

@ste93cry
Copy link
Collaborator

ste93cry commented Nov 1, 2019

Thank you very much for your contribution, LGTM 🎉

@ste93cry ste93cry merged commit 152117a into getsentry:master Nov 1, 2019
@TheLevti TheLevti deleted the feature/908-suggest-monolog branch November 1, 2019 21:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

Assignees
No one assigned
Labels
Type: Improvement
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Monolog package non dev requirement
2 participants
@TheLevti @ste93cry