-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support Litestar #2413
Comments
Hi! Let us know if there is any extra details that may be helpful in this. We may have some resources we can throw at this to tackle the PR but I am doubtful as it stands right now (at least for a little while!).. but we would love to see native support for this as well :) |
Hey @JacobCoffee, thanks for the support! Same goes the other way -- if anyone feels like tackling this, we're happy to provide support. The case of Litestar as an integration is special since we've already integrated with Starlite, so whoever takes this on doesn't have to start from square one but rather build on what we already have, which should make it easier. Folks reading this, please give the original issue a 👍🏻 if this is something you want, it helps us prioritize this internally as well. |
@sentrivana I'd like to take a crack at this. I looked at the existing integration with Starlite, and like you said it shouldn't be too difficult to use that as a base for the |
Thank you @guacs! Exactly, I'd start by just copying the Starlite integration into a new file and then taking it from there. Additionally there is a few housekeeping places that will need changing throughout the SDK, like adding Litestar to |
@sentrivana @guacs any news on this? |
No news yet @jeanlst -- same situation as before, we probably won't get around to doing this soon, but happy to provide support if anyone wants to give it a try. |
Sorry I've just gotten quite busy for a while! Unfortunately, I think it may be a few weeks before I'll get a chance to work on this :/ |
Adds support for Litestar through a new LitestarIntegration based on porting the existing StarliteIntegration. Starlite was renamed Litestar as part of its move to version 2.0. Closes #2413 --------- Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io> Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com> Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Adds support for Litestar through a new LitestarIntegration based on porting the existing StarliteIntegration. Starlite was renamed Litestar as part of its move to version 2.0. Closes getsentry#2413 --------- Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io> Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com> Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Problem Statement
Starlite was renamed to Litestar. Since we already have a Starlite integration, adding support for Litestar should in the ideal case just be a matter of checking the changelog for the new major and creating a new integration based on the existing one.
Solution Brainstorm
Write the new integration.
The text was updated successfully, but these errors were encountered: