Skip to content

ref(redis): Use new scopes API #2854

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 19, 2024

Update our redis integration to use the new scopes API.


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review March 19, 2024 14:23
@sentrivana sentrivana changed the title ref(redis): Update to use new scopes API ref(redis): Use new scopes API Mar 19, 2024
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@sentrivana sentrivana merged commit 27d5ee1 into sentry-sdk-2.0 Mar 20, 2024
@sentrivana sentrivana deleted the ivana/2.0/new-scopes-redis branch March 20, 2024 10:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants