Skip to content

test: fix test_installed_modules #3309

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Jul 19, 2024

Use non-cached _generate_installed_modules, instead

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (531f8f7) to head (f08b7ad).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3309      +/-   ##
==========================================
- Coverage   79.47%   79.46%   -0.02%     
==========================================
  Files         133      133              
  Lines       14290    14290              
  Branches     3003     3003              
==========================================
- Hits        11357    11355       -2     
  Misses       2089     2089              
- Partials      844      846       +2     

see 2 files with indirect coverage changes

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/fix-ci branch from b000d1c to f08b7ad Compare July 19, 2024 09:56
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@antonpirker antonpirker merged commit 6f814e6 into master Jul 19, 2024
123 checks passed
@antonpirker antonpirker deleted the szokeasaurusrex/fix-ci branch July 19, 2024 10:14
sentrivana pushed a commit that referenced this pull request Jul 25, 2024
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants