Skip to content

feat(integrations): Add disabled_integrations #3328

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 23, 2024

Add a new init option called disabled_integrations, which is a sequence of integrations that will not be enabled regardless of what auto_enabling_integrations and default_integrations is set to.

Docs getsentry/sentry-docs#10808
Closes #3166

@sentrivana sentrivana changed the title Add disabled_integrations feat(integrations): Add disabled_integrations Jul 23, 2024
@sentrivana sentrivana marked this pull request as ready for review July 23, 2024 13:29
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would prefer we make fewer public API guarantees here to make potential future implementation changes easier

@sentrivana sentrivana enabled auto-merge (squash) July 23, 2024 14:32
@sentrivana sentrivana merged commit 357d6f5 into master Jul 23, 2024
122 of 123 checks passed
@sentrivana sentrivana deleted the ivana/disable-integrations branch July 23, 2024 14:37
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Add a new init option called disabled_integrations, which is a sequence of integrations that will not be enabled regardless of what auto_enabling_integrations and default_integrations is set to.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make disabling individual integrations easier
3 participants