Skip to content

fix(api): push_scope deprecation warning #3355

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

szokeasaurusrex
Copy link
Member

Although push_scope was meant to be deprecated since Sentry
SDK 2.0.0, calling push_scope did not raise a deprecation
warning. Now, it does.

Fixes #3347

@szokeasaurusrex szokeasaurusrex linked an issue Jul 26, 2024 that may be closed by this pull request
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/push_scope-2-deprecation branch from b74c30e to 54ad7ed Compare July 26, 2024 11:57
szokeasaurusrex added a commit that referenced this pull request Jul 26, 2024
Although `push_scope` was meant to be deprecated since Sentry
SDK 2.0.0, calling `push_scope` did not raise a deprecation
warning. Now, it does.

Fixes #3347
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/push_scope-1 branch from d09b113 to c8e93af Compare July 26, 2024 11:58
Base automatically changed from szokeasaurusrex/push_scope-1 to master July 26, 2024 13:27
Although `push_scope` was meant to be deprecated since Sentry
SDK 2.0.0, calling `push_scope` did not raise a deprecation
warning. Now, it does.

Fixes #3347
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/push_scope-2-deprecation branch from 54ad7ed to 21eb829 Compare July 26, 2024 13:30
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) July 26, 2024 13:30
@szokeasaurusrex szokeasaurusrex merged commit 194e430 into master Jul 26, 2024
123 of 124 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/push_scope-2-deprecation branch July 26, 2024 13:40
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
…y#3355)

Although `push_scope` was meant to be deprecated since Sentry
SDK 2.0.0, calling `push_scope` did not raise a deprecation
warning. Now, it does.

Fixes getsentry#3347
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate sentry_sdk.push_scope
2 participants