Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expose custom_repr function that precedes safe_repr invocation in serializer #3438

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Expose custom_repr function that precedes safe_repr invocation in serializer #3438

merged 1 commit into from
Aug 12, 2024

Conversation

sl0thentr0py
Copy link
Member

closes #3427

@sl0thentr0py sl0thentr0py force-pushed the neel/custom-repr branch 2 times, most recently from 5c20712 to e0f04ea Compare August 12, 2024 13:52
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 14769 tests with 25 failed, 12844 passed and 1900 skipped.

View the full list of failed tests

py3.11-common

  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_cause

    tests/test_exceptiongroup.py:206: in test_exception_chain_cause
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_context

    tests/test_exceptiongroup.py:246: in test_exception_chain_context
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup

    tests/test_exceptiongroup.py:45: in test_exceptiongroup
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup_simple

    tests/test_exceptiongroup.py:161: in test_exceptiongroup_simple
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_simple_exception

    tests/test_exceptiongroup.py:285: in test_simple_exception
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'

py3.11-gevent

  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_cause

    tests/test_exceptiongroup.py:206: in test_exception_chain_cause
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_context

    tests/test_exceptiongroup.py:246: in test_exception_chain_context
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup

    tests/test_exceptiongroup.py:45: in test_exceptiongroup
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup_simple

    tests/test_exceptiongroup.py:161: in test_exceptiongroup_simple
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_simple_exception

    tests/test_exceptiongroup.py:285: in test_simple_exception
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'

py3.12-common

  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_cause

    tests/test_exceptiongroup.py:206: in test_exception_chain_cause
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_context

    tests/test_exceptiongroup.py:246: in test_exception_chain_context
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup

    tests/test_exceptiongroup.py:45: in test_exceptiongroup
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup_simple

    tests/test_exceptiongroup.py:161: in test_exceptiongroup_simple
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_simple_exception

    tests/test_exceptiongroup.py:285: in test_simple_exception
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'

py3.12-gevent

  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_cause

    tests/test_exceptiongroup.py:206: in test_exception_chain_cause
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_context

    tests/test_exceptiongroup.py:246: in test_exception_chain_context
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup

    tests/test_exceptiongroup.py:45: in test_exceptiongroup
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup_simple

    tests/test_exceptiongroup.py:161: in test_exceptiongroup_simple
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_simple_exception

    tests/test_exceptiongroup.py:285: in test_simple_exception
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'

py3.13-common

  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_cause

    tests/test_exceptiongroup.py:206: in test_exception_chain_cause
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exception_chain_context

    tests/test_exceptiongroup.py:246: in test_exception_chain_context
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup

    tests/test_exceptiongroup.py:45: in test_exceptiongroup
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_exceptiongroup_simple

    tests/test_exceptiongroup.py:161: in test_exceptiongroup_simple
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:904: in exceptions_from_error_tuple
        (_, exceptions) = exceptions_from_error(
    sentry_sdk/utils.py:814: in exceptions_from_error
        parent = single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'
  • Class name: tests.test_exceptiongroup
    Test name: test_simple_exception

    tests/test_exceptiongroup.py:285: in test_simple_exception
        (event, _) = event_from_exception(
    sentry_sdk/utils.py:1050: in event_from_exception
        "values": exceptions_from_error_tuple(
    sentry_sdk/utils.py:918: in exceptions_from_error_tuple
        single_exception_from_error_tuple(
    sentry_sdk/utils.py:734: in single_exception_from_error_tuple
        custom_repr = client_options["custom_repr"]
    E   KeyError: 'custom_repr'

sentrivana
sentrivana approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see one comment

Please also add to docs

sentry_sdk/serializer.py Show resolved Hide resolved
@sl0thentr0py sl0thentr0py mentioned this pull request Aug 12, 2024
Merged
@sl0thentr0py
Copy link
Member Author

docs here
getsentry/sentry-docs#11059

@sl0thentr0py sl0thentr0py merged commit 4858996 into master Aug 12, 2024
124 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/custom-repr branch August 12, 2024 14:32
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
@sl0thentr0py @arjenzorgdoc
Expose custom_repr function that precedes safe_repr invocation in ser…
cb28ad2 
…ializer (getsentry#3438)

closes getsentry#3427
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose custom safe_repr config
2 participants
@sl0thentr0py @sentrivana