Skip to content

fix: Don't use deprecated logger.warn #3552

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: Don't use deprecated logger.warn #3552

merged 1 commit into from
Sep 20, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 20, 2024

logger.warn() is deprecated in favor of logger.warning().

We were using logger.warn() in two places. I changed one to debug to not pollute folks' logs and the other one to logger.warning() since it's in the tests.

@sentrivana sentrivana enabled auto-merge (squash) September 20, 2024 12:06
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@sentrivana sentrivana merged commit ed614c0 into master Sep 20, 2024
123 of 124 checks passed
@sentrivana sentrivana deleted the ivana/logger-warn branch September 20, 2024 12:14
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (64e2977) to head (f796ddc).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/langchain.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3552      +/-   ##
==========================================
- Coverage   84.51%   84.51%   -0.01%     
==========================================
  Files         133      133              
  Lines       13837    13837              
  Branches     2927     2927              
==========================================
- Hits        11695    11694       -1     
  Misses       1415     1415              
- Partials      727      728       +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/langchain.py 69.87% <0.00%> (ø)

... and 1 file with indirect coverage changes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants