Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(django): Add SpotlightMiddleware when Spotlight is enabled #3600

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Oct 2, 2024

This patch replaces Django's debug error page with Spotlight when
it is enabled and is running. It bails when DEBUG is False or
when it cannot connect to the Spotlight web server.

BYK added 3 commits October 2, 2024 16:32
This patch replaces Django's debug error page with Spotlight when
it is enabled and is running. It bails when `DEBUG` is `False` or
when it cannot connect to the Spotlight web server.
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes missing coverage. Please review.

Project coverage is 84.27%. Comparing base (2bfce50) to head (344af85).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/spotlight.py 51.61% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3600      +/-   ##
==========================================
- Coverage   84.34%   84.27%   -0.07%     
==========================================
  Files         133      133              
  Lines       13994    14024      +30     
  Branches     2951     2955       +4     
==========================================
+ Hits        11803    11819      +16     
- Misses       1450     1465      +15     
+ Partials      741      740       -1     
Files with missing lines Coverage Δ
sentry_sdk/client.py 83.49% <100.00%> (ø)
sentry_sdk/spotlight.py 65.57% <51.61%> (-15.08%) ⬇️

... and 3 files with indirect coverage changes

@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Oct 4, 2024
@sentrivana sentrivana merged commit 00f8140 into getsentry:master Oct 4, 2024
136 of 139 checks passed
@BYK BYK deleted the byk/feat/spotlight-on-error branch October 16, 2024 16:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants