Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Open relevant error when SpotlightMiddleware is on #3614

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Oct 4, 2024

This fixes an issue with the recent SpotlightMiddleware patch where the error triggered the page was not highlighted/opened automatically. It changes the semapics of capture_event and methods depending on this a bit: we now return the event_id if the error is sent to spotlight even if it was not sent upstream to Sentry servers.

This fixes an issue with the recent SpotlightMiddleware patch where the error triggered the page was not highlighted/opened automatically. It changes the semapics of `capture_event` and methods depending on this a bit: we now return the event_id if the error is sent to spotlight even if it was not sent upstream to Sentry servers.
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.28%. Comparing base (be64348) to head (e262a10).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/spotlight.py 0.00% 3 Missing ⚠️
sentry_sdk/client.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3614   +/-   ##
=======================================
  Coverage   84.27%   84.28%           
=======================================
  Files         133      133           
  Lines       14024    14024           
  Branches     2955     2954    -1     
=======================================
+ Hits        11819    11820    +1     
+ Misses       1465     1464    -1     
  Partials      740      740           
Files with missing lines Coverage Δ
sentry_sdk/client.py 83.74% <88.88%> (+0.24%) ⬆️
sentry_sdk/spotlight.py 65.57% <0.00%> (ø)

@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Oct 7, 2024
@sentrivana sentrivana enabled auto-merge (squash) October 7, 2024 12:44
@sentrivana sentrivana merged commit a31c54f into getsentry:master Oct 7, 2024
135 of 138 checks passed
@BYK BYK deleted the byk/fix/open-error-spotlight branch October 7, 2024 12:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants