Skip to content

Remove ensure_integration_enabled_async #3632

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

sentrivana
Copy link
Contributor

Removing ensure_integration_enabled_async since there are some unresolved issues with it.

This should be ok to just remove (as opposed to deprecate) since it's only meant to be used internally.

Closes #2892

Copy link

codecov bot commented Oct 8, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
14851 1 14850 4376
View the top 1 failed tests by shortest run time
tests.test_transport test_transport_works[threads-False-gzip-None-True-close-True]
Stack Traces | 0.668s run time
tests/test_transport.py:175: in test_transport_works
    assert not err and not out
E   assert (not '--- Logging error ---\nTraceback (most recent call last):\n  File ".../hostedtoolcache/Python/3.6.15.../x64/lib/python3...lhandlers\n    return old_callhandlers(self, record)\nMessage: \'background worker got kill request\'\nArguments: ()\n')

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana marked this pull request as ready for review October 8, 2024 14:21
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sentrivana sentrivana enabled auto-merge (squash) October 8, 2024 14:49
@sentrivana sentrivana merged commit ce604f9 into master Oct 9, 2024
136 checks passed
@sentrivana sentrivana deleted the ivana/remove-ensure-async branch October 9, 2024 07:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure_integration_enabled_async doesn't work sometimes
2 participants