Skip to content

Update openai.py #3807

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update openai.py #3807

merged 1 commit into from
Nov 19, 2024

Conversation

sourceful-rob
Copy link
Contributor

Update the arguments in the start_span function. pecifically, changing the deprecated "description" to "name". This was causing a deprecation warning when running tests.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

Update the arguments in the start_span function. pecifically, changing the deprecated "description" to "name". This was causing a deprecation warning when running tests.
@sentrivana
Copy link
Contributor

Thank you @sourceful-rob for catching this!

@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (d894fc2) to head (f22b59f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3807      +/-   ##
==========================================
- Coverage   79.89%   79.87%   -0.02%     
==========================================
  Files         137      137              
  Lines       15371    15371              
  Branches     2608     2608              
==========================================
- Hits        12281    12278       -3     
- Misses       2221     2223       +2     
- Partials      869      870       +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/openai.py 80.15% <ø> (ø)

... and 3 files with indirect coverage changes

@sentrivana sentrivana enabled auto-merge (squash) November 19, 2024 15:20
@sentrivana sentrivana merged commit 01146bd into getsentry:master Nov 19, 2024
137 of 139 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants