Skip to content

Debug output from Sentry logs should always be debug level. #4224

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Apr 1, 2025

Prevent emitting too many log messages.

@antonpirker antonpirker requested a review from a team as a code owner April 1, 2025 12:32
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (d0d70a5) to head (f8a715b).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4224      +/-   ##
==========================================
- Coverage   79.48%   79.46%   -0.02%     
==========================================
  Files         141      141              
  Lines       15809    15807       -2     
  Branches     2703     2703              
==========================================
- Hits        12565    12561       -4     
- Misses       2382     2383       +1     
- Partials      862      863       +1     
Files with missing lines Coverage Δ
sentry_sdk/client.py 77.95% <100.00%> (-0.88%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Although maybe the higher-severity messages (e.g. warn, error, and fatal) should get mapped to the info level?

@antonpirker antonpirker merged commit 438ee01 into master Apr 2, 2025
139 checks passed
@antonpirker antonpirker deleted the antonpirker/denote-sentry-logs-messages-to-debug branch April 2, 2025 14:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants