-
Notifications
You must be signed in to change notification settings - Fork 551
ref: Move consts, utils from integrations/opentelemetry/
#4272
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
…o ivana/potel/move-propagator
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## potel-base #4272 +/- ##
==============================================
- Coverage 83.55% 83.54% -0.01%
==============================================
Files 144 144
Lines 14663 14631 -32
Branches 2325 2325
==============================================
- Hits 12251 12223 -28
+ Misses 1694 1690 -4
Partials 718 718
|
|
||
tracer = otel_trace.get_tracer(__name__) | ||
|
||
|
||
def get_span_status_from_http_code(http_status_code): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now in tracing_utils.py
…o ivana/potel/move-propagator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, have some questions though
Moving stuff out of
integrations/opentelemetry/
step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK. This movessentry_sdk/integrations/opentelemetry/{utils,consts}.py
->sentry_sdk/opentelemetry/{utils,consts}.py
.There's quite some stuff moving around in this PR in order to remove circular dependencies that have to do with
tracing.py
:get_span_status_from_http_code
fromtracing.py
is now intracing_utils.py
tracing.py
are now inconsts.py
Additionally, Sphinx was unhappy, so tweaked the way we type some things in
api.py
and_init_implementation.py
.I'll possibly follow this up with creating a nice structure for the tracing files, maybe a common
tracing
directory withtracing.py
,tracing_utils.py
->utils.py
, and dedicatedconsts.py
.Ref #3853