Skip to content

ref: Remove _capture_experimental_log scope parameter #4424

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

szokeasaurusrex
Copy link
Member

We are always just using the current scope anyway; it is less confusing if we eliminate the parameter

Stacked on:

@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner May 28, 2025 16:25
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (c2d5a76) to head (6eba950).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/client.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4424      +/-   ##
==========================================
+ Coverage   80.67%   80.68%   +0.01%     
==========================================
  Files         142      142              
  Lines       15982    15986       +4     
  Branches     2729     2732       +3     
==========================================
+ Hits        12893    12899       +6     
+ Misses       2232     2231       -1     
+ Partials      857      856       -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/logging.py 82.69% <ø> (-0.12%) ⬇️
sentry_sdk/logger.py 100.00% <100.00%> (ø)
sentry_sdk/client.py 79.57% <88.88%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/logs-scopes branch from 4280451 to 642e3db Compare June 3, 2025 12:22
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/logs-user-attributes branch 2 times, most recently from a903eb6 to 285abb0 Compare June 3, 2025 12:25
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/logs-scopes branch from 642e3db to b553ca0 Compare June 3, 2025 12:25
We are always just using the current scope anyway; it is less confusing if we eliminate the parameter
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/logs-scopes branch from b553ca0 to 6eba950 Compare June 5, 2025 12:47
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/logs-user-attributes branch from 285abb0 to 076e4d1 Compare June 5, 2025 12:47
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Base automatically changed from szokeasaurusrex/logs-user-attributes to master June 5, 2025 13:39
@szokeasaurusrex szokeasaurusrex merged commit 7f8571c into master Jun 5, 2025
136 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/logs-scopes branch June 5, 2025 13:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants