Fix CI, adapt to new redis-py release #4431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4431 +/- ##
==========================================
+ Coverage 80.61% 80.67% +0.05%
==========================================
Files 142 142
Lines 15973 15982 +9
Branches 2727 2729 +2
==========================================
+ Hits 12877 12893 +16
+ Misses 2240 2233 -7
Partials 856 856
|
sentrivana
commented
Jun 2, 2025
| @@ -188,7 +188,7 @@ class SDKInfo(TypedDict): | |||
| "monitor_slug": Optional[str], | |||
| "platform": Literal["python"], | |||
| "profile": object, # Should be sentry_sdk.profiler.Profile, but we can't import that here due to circular imports | |||
| "release": str, | |||
| "release": Optional[str], | |||
There was a problem hiding this comment.
mypy was complaining because of environment and release potentially being None here
sentrivana
commented
Jun 2, 2025
| @@ -41,13 +41,21 @@ async def _sentry_execute(self, *args, **kwargs): | |||
| origin=SPAN_ORIGIN, | |||
| ) as span: | |||
| with capture_internal_exceptions(): | |||
| try: | |||
| command_seq = self._execution_strategy._command_queue | |||
There was a problem hiding this comment.
redis-py PR that introduced this
sentrivana
commented
Jun 2, 2025
| @@ -36,11 +36,19 @@ def _set_async_cluster_db_data(span, async_redis_cluster_instance): | |||
| def _set_async_cluster_pipeline_db_data(span, async_redis_cluster_pipeline_instance): | |||
| # type: (Span, AsyncClusterPipeline[Any]) -> None | |||
| with capture_internal_exceptions(): | |||
| client = getattr(async_redis_cluster_pipeline_instance, "cluster_client", None) | |||
There was a problem hiding this comment.
redis-py PR that introduced this
antonpirker
approved these changes
Jun 2, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three new versions of things that need addressing:
event_loopfixtureexecution_strategyabstraction to async cluster pipelines as well, so the commands are no longer accessible directly and need to be accessed via thestrategy_clientattribute on async cluster pipeline tocluster_client