-
Notifications
You must be signed in to change notification settings - Fork 549
Make DedupeIntegration
more memory efficient.
#4446
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Draft
antonpirker
wants to merge
10
commits into
master
Choose a base branch
from
antonpirker/make-dedupe-integration-more-memory-efficient
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Make DedupeIntegration
more memory efficient.
#4446
antonpirker
wants to merge
10
commits into
master
from
antonpirker/make-dedupe-integration-more-memory-efficient
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 33 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
DedupeIntegration
more memory efficient.
@antonpirker can't you just |
i thought about that too. but garbage collection moves objects around. so id(exc) could be different when we safe it and when we compare it... |
sl0thentr0py
requested changes
Jun 5, 2025
The |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users reported that the
DedupeIntegration
can use up a lot of memory, because it keeps a full exception in memory for checking if it has seen this exception already.Depending on the users code those exception objects can be big because they also include the traceback and local variables (which can be huge).
Idea is now to not save the whole exception but just a hash of the important parts of the exception to decide if we have seen this exception again.
fixes #3165
fixes #4327