Skip to content

fix(logs): Don't gate user behind send_default_pii #4453

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad self-assigned this Jun 9, 2025
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner June 9, 2025 21:33
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.65%. Comparing base (7f8571c) to head (f6304d4).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4453      +/-   ##
==========================================
- Coverage   80.68%   80.65%   -0.03%     
==========================================
  Files         142      142              
  Lines       15986    15986              
  Branches     2732     2732              
==========================================
- Hits        12898    12894       -4     
- Misses       2230     2232       +2     
- Partials      858      860       +2     
Files with missing lines Coverage Δ
sentry_sdk/client.py 79.57% <100.00%> (ø)

... and 3 files with indirect coverage changes

@szokeasaurusrex
Copy link
Member

Let's wait until my comment here is resolved before reviewing

@AbhiPrasad AbhiPrasad merged commit 1433ec2 into master Jun 10, 2025
137 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-send-default-pii branch June 10, 2025 13:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants