Skip to content

feat(sessions): Add top-level start- and end session methods #4474

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Jun 16, 2025

Closes #4473.

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review June 16, 2025 10:05
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner June 16, 2025 10:05
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (4a0e5ed) to head (48f483f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4474      +/-   ##
==========================================
+ Coverage   80.67%   80.68%   +0.01%     
==========================================
  Files         156      156              
  Lines       16461    16467       +6     
  Branches     2799     2799              
==========================================
+ Hits        13280    13287       +7     
  Misses       2296     2296              
+ Partials      885      884       -1     
Files with missing lines Coverage Δ
sentry_sdk/__init__.py 100.00% <ø> (ø)
sentry_sdk/api.py 80.40% <100.00%> (+0.82%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please see comment first

@@ -0,0 +1,50 @@
import sentry_sdk
Copy link
Contributor

@sentrivana sentrivana Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these tests to the existing tests/test_sessions.py and delete this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@szokeasaurusrex szokeasaurusrex force-pushed the cursor/implement-github-feature-and-add-tests-a124 branch from e897304 to 7bc76ed Compare June 24, 2025 15:19
@szokeasaurusrex szokeasaurusrex force-pushed the cursor/implement-github-feature-and-add-tests-a124 branch from 7bc76ed to 0626243 Compare June 24, 2025 15:21
Closes #4474

Co-authored-by: Daniel Szoke <daniel.szoke@sentry.io>
@szokeasaurusrex szokeasaurusrex force-pushed the cursor/implement-github-feature-and-add-tests-a124 branch from 0626243 to 48f483f Compare June 24, 2025 15:22
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) June 24, 2025 15:23
@szokeasaurusrex szokeasaurusrex merged commit 8b6e5ad into master Jun 24, 2025
136 checks passed
@szokeasaurusrex szokeasaurusrex deleted the cursor/implement-github-feature-and-add-tests-a124 branch June 24, 2025 15:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add session-related methods to top-level API
3 participants