-
Notifications
You must be signed in to change notification settings - Fork 549
feat(sessions): Add top-level start- and end session methods #4474
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(sessions): Add top-level start- and end session methods #4474
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4474 +/- ##
==========================================
+ Coverage 80.67% 80.68% +0.01%
==========================================
Files 156 156
Lines 16461 16467 +6
Branches 2799 2799
==========================================
+ Hits 13280 13287 +7
Misses 2296 2296
+ Partials 885 884 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please see comment first
tests/test_api_sessions.py
Outdated
@@ -0,0 +1,50 @@ | |||
import sentry_sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move these tests to the existing tests/test_sessions.py
and delete this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
e897304
to
7bc76ed
Compare
7bc76ed
to
0626243
Compare
Closes #4474 Co-authored-by: Daniel Szoke <daniel.szoke@sentry.io>
0626243
to
48f483f
Compare
Closes #4473.