Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(profiling): Add actual activeThreadId to Profiles #3338

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix

📜 Description

the missing active thread id cause the Sentry backend to not calculate aggregate data, as those are calculated only for the active thread

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 456.55 ms 527.06 ms 70.51 ms
Size 17.73 MiB 19.85 MiB 2.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3ffcddd 302.92 ms 315.80 ms 12.88 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
abb7058 370.27 ms 389.58 ms 19.31 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
0677344 327.74 ms 337.14 ms 9.40 ms
9c48b2c 349.24 ms 385.96 ms 36.72 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms

App size

Revision Plain With Sentry Diff
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
9c48b2c 17.73 MiB 19.80 MiB 2.07 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 389.43 ms 420.04 ms 30.61 ms
Size 7.15 MiB 8.12 MiB 999.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms
0677344+dirty 288.40 ms 391.44 ms 103.04 ms
3853f43+dirty 278.12 ms 338.72 ms 60.60 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms

App size

Revision Plain With Sentry Diff
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB
0677344+dirty 7.15 MiB 8.07 MiB 949.80 KiB
3853f43+dirty 7.15 MiB 8.08 MiB 959.34 KiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB

@krystofwoldrich krystofwoldrich merged commit 21465bc into main Oct 11, 2023
@krystofwoldrich krystofwoldrich deleted the kw-fix-profiles-active-thread-id branch October 11, 2023 21:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants