Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(expo): Add concrete error messages for RN bundle build phase patch #3626

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Will help us and users determinate why the build phase was not updated.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4faf667

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1207.94 ms 1215.16 ms 7.23 ms
Size 2.36 MiB 2.91 MiB 558.17 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman merged commit e0f0885 into main Feb 23, 2024
53 of 56 checks passed
@lucas-zimerman lucas-zimerman deleted the kw-expo-plugin-rn-build-phase-error-messages branch February 23, 2024 12:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants