Change React Native Version import to the one from Platform #3949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The import for selection of React Native version, both for type and value happens via JS constant, while there's an documented way to get it from
Platform
: https://reactnative.dev/docs/platform#constantsIt's also available in 0.65 which makes it work for all versions:
https://reactnative-archive-august-2023.netlify.app/docs/0.65/platform#constants
💡 Motivation and Context
While working with other repos than
react-native
likereact-native-tvos
orreact-native-web
with certain TS configs, there are issues like this one:This PR solves this import issue
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps