-
-
Notifications
You must be signed in to change notification settings - Fork 344
fix build multi variant releases #4125
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix build multi variant releases #4125
Conversation
Hi and thank you for the contribution!
|
Hi @omidshafaei, |
Hi @lucas-zimerman, @krystofwoldrich. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
📢 Type of change
📜 Description
When I want to build for multi-variant projects, it gives me an error.
During troubleshooting, I realized that for all variants, only one version of the source map is uploaded.
By checking the sentry .gradle file, I realized that three variables are defined globally, but they are used inside the loop, and this makes these three variables retain the value of the last round of the loop. For this reason, the duplicate source map is uploaded.
For example, if I want to build for armeabi-v7a, x86, arm64-v8a and x86_64 variants, the source map for x86_64 will be uploaded four times because it is the last round of the loop.
💡 Motivation and Context
This pull request solves the problem of duplicate source map upload for all project variants.
💚 How did you test it?
Just create a multi-variant project and build it.
This is my build logs. As you can see, one version has been uploaded for all source map upload tasks:
As can be seen in the logs above, this log has been repeated four times:
Uploading sourcemaps for release com.x.appr@0.8.9+8009004 distribution 8009004
📝 Checklist
sendDefaultPII
is enabled