Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(ci): Installs corepack before enabling in native tests #4275

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix(ci): Installs corepack before enabling in native tests #4275

merged 1 commit into from
Nov 14, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Nov 14, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Installs corepack before enabling in native tests (similar to #4273) after the upgrade to macos-15 with #4274 where corepack is not available

⚠️ The 6 failing sample iOS app checks are due to a missing provisioning profile

💡 Motivation and Context

Failed test on CI (example)

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis marked this pull request as ready for review November 14, 2024 10:58
@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 427.59 ms 434.68 ms 7.09 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eb1e19f 433.55 ms 444.90 ms 11.35 ms
27ef4ee 317.40 ms 321.70 ms 4.30 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
0677344 327.74 ms 337.14 ms 9.40 ms
abb7058 370.27 ms 389.58 ms 19.31 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
d43a46b 454.22 ms 477.79 ms 23.57 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
0ebca77 414.93 ms 444.49 ms 29.56 ms

App size

Revision Plain With Sentry Diff
eb1e19f 17.74 MiB 20.08 MiB 2.34 MiB
27ef4ee 17.73 MiB 19.82 MiB 2.08 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
d43a46b 17.73 MiB 20.06 MiB 2.33 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
0ebca77 17.73 MiB 19.95 MiB 2.21 MiB

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 399.66 ms 449.37 ms 49.71 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ac41368+dirty 395.91 ms 451.17 ms 55.26 ms
8c88ac7+dirty 402.72 ms 434.32 ms 31.60 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms
4cc5c27+dirty 398.36 ms 452.50 ms 54.14 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms
0d3e677+dirty 384.24 ms 431.45 ms 47.21 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
1faf8e3+dirty 412.83 ms 470.49 ms 57.66 ms

App size

Revision Plain With Sentry Diff
ac41368+dirty 7.15 MiB 8.39 MiB 1.24 MiB
8c88ac7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB
4cc5c27+dirty 7.15 MiB 8.22 MiB 1.07 MiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB
0d3e677+dirty 7.15 MiB 8.35 MiB 1.20 MiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
1faf8e3+dirty 7.15 MiB 8.35 MiB 1.20 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.25 ms 1234.31 ms 9.06 ms
Size 2.92 MiB 3.66 MiB 756.70 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
baa882f+dirty 1235.48 ms 1229.02 ms -6.46 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms
9cd0e9f+dirty 1244.61 ms 1247.43 ms 2.82 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
d8668ce+dirty 1249.70 ms 1242.31 ms -7.39 ms
e5bc97b+dirty 1229.17 ms 1227.64 ms -1.54 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
2ec71da+dirty 1230.29 ms 1239.50 ms 9.21 ms
5571a20+dirty 1228.09 ms 1233.45 ms 5.36 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms

App size

Revision Plain With Sentry Diff
baa882f+dirty 2.92 MiB 3.64 MiB 738.56 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB
9cd0e9f+dirty 2.92 MiB 3.64 MiB 741.23 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
d8668ce+dirty 2.92 MiB 3.64 MiB 742.99 KiB
e5bc97b+dirty 2.92 MiB 3.66 MiB 758.40 KiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
2ec71da+dirty 2.92 MiB 3.69 MiB 791.06 KiB
5571a20+dirty 2.92 MiB 3.48 MiB 575.54 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB

lucas-zimerman
lucas-zimerman approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman merged commit 57448c5 into main Nov 14, 2024
60 of 73 checks passed
@lucas-zimerman lucas-zimerman deleted the antonis/ci-native-tests-corepack branch November 14, 2024 11:24
@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.08 ms 1227.35 ms -5.73 ms
Size 2.36 MiB 3.10 MiB 752.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
baa882f+dirty 1218.00 ms 1227.04 ms 9.04 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
9cd0e9f+dirty 1224.94 ms 1239.88 ms 14.94 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
d8668ce+dirty 1225.18 ms 1228.08 ms 2.90 ms
e5bc97b+dirty 1230.63 ms 1234.83 ms 4.20 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
2ec71da+dirty 1225.85 ms 1231.57 ms 5.72 ms
5571a20+dirty 1203.57 ms 1204.57 ms 1.00 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms

App size

Revision Plain With Sentry Diff
baa882f+dirty 2.36 MiB 3.08 MiB 731.91 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
9cd0e9f+dirty 2.36 MiB 3.08 MiB 735.56 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
d8668ce+dirty 2.36 MiB 3.08 MiB 737.08 KiB
e5bc97b+dirty 2.36 MiB 3.10 MiB 753.14 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
2ec71da+dirty 2.36 MiB 3.13 MiB 784.66 KiB
5571a20+dirty 2.36 MiB 2.92 MiB 569.93 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @lucas-zimerman