-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(replay): browserReplayIntegration should not be included by default #4308
Conversation
Android (new) Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for back-porting this fix 🙇
l: The Lint failure could be fixed by formatting the sdk.test.ts
.
I think the rest of the CI check failures are unrelated with this PR (signing issues, testing device availability etc).
Sadly, the v5 CI is out of date, we have to fix it first, unrelated to changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We should make a follow-up PR to fix CI
Android (legacy) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
browserReplayIntegration
should not be included by default #4270 for v5