Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(replay): Backport iOS masking fixes from RN SDK v6 #4309

Merged
merged 16 commits into from
Dec 3, 2024
Merged

fix(replay): Backport iOS masking fixes from RN SDK v6 #4309

merged 16 commits into from
Dec 3, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich changed the title fix(tracing-ttd): Implement fallback system to screens that aren't re… fix(replay): Backport iOS masking fixes from RN SDK v6 Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 367.60 ms 401.96 ms 34.36 ms
Size 7.15 MiB 8.39 MiB 1.24 MiB

lucas-zimerman
lucas-zimerman reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good! but I would way the CI to be fixed before merging it

antonis
antonis approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and includes all the code of the PRs in the description 🎉
Thank you for porting the iOS masking fixes!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.43 ms 1221.90 ms -6.53 ms
Size 2.36 MiB 3.15 MiB 803.28 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1244.24 ms 1244.02 ms -0.22 ms
Size 2.92 MiB 3.71 MiB 808.34 KiB

Base automatically changed from kw/backport/replay-web-fix to v5 December 3, 2024 09:29
@krystofwoldrich krystofwoldrich merged commit b4c06ca into v5 Dec 3, 2024
55 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/backport/replay-ios-masking-fixes branch December 3, 2024 09:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 449.20 ms 449.29 ms 0.09 ms
Size 17.73 MiB 20.11 MiB 2.38 MiB

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman left review comments

@antonis antonis antonis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krystofwoldrich @antonis @lucas-zimerman