Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update scripts/update-cocoa.sh to 8.42.0-beta.2 #4335

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

krystofwoldrich
Copy link
Member

Bump to cocoa beta to include latest replay fixes. Mainly masking improvements (for fast animations).

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 354.20 ms 414.60 ms 60.40 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

@krystofwoldrich
Copy link
Member Author

Sadly CI is not happy. I'm looking into this.

[RNSentry] Compiling RNSentryReplayUnmask.mm
[RNSentry] Compiling RNSentryReplayMask.mm
[React-RCTFabric] Linking RCTFabric
[RNSentry] Compiling RNSentryReplayBreadcrumbConverterHelper.m
Error: include of non-modular header inside framework module 'Sentry.SentrySessionReplayIntegration_Hybrid': '/Users/runner/work/sentry-react-native/sentry-react-native/dev-packages/e2e-tests/react-native-versions/0.76.0/RnDiffApp/ios/Pods/Sentry/Sources/Sentry/include/SentrySessionReplayIntegration.h' [-Werror,-Wnon-modular-include-in-framework-module]
#    import "SentrySessionReplayIntegration.h"
            ^
Error: could not build module 'Sentry'
#import <Sentry/SentryDefines.h>
 ~~~~~~~^

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 445.88 ms 434.30 ms -11.58 ms
Size 17.74 MiB 20.09 MiB 2.35 MiB

Copy link
Contributor

github-actions bot commented Dec 2, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1246.66 ms 1244.80 ms -1.86 ms
Size 2.92 MiB 3.69 MiB 789.80 KiB

Copy link
Contributor

github-actions bot commented Dec 2, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.35 ms 1238.75 ms 1.40 ms
Size 2.36 MiB 3.12 MiB 778.55 KiB

@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Dec 2, 2024

Will be released in a new beta of sentry-cocoa

@krystofwoldrich krystofwoldrich changed the title chore: update scripts/update-cocoa.sh to 8.42.0-beta.1 chore: update scripts/update-cocoa.sh to 8.42.0-beta.2 Dec 5, 2024
@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Dec 5, 2024

I've bumped cocoa to 8.42.0-beta.2, if CI will be happy we can merge this.

@krystofwoldrich krystofwoldrich changed the base branch from 6.4.0-beta to publish/6.5.0-beta December 5, 2024 15:27
@krystofwoldrich krystofwoldrich merged commit 239d621 into publish/6.5.0-beta Dec 5, 2024
58 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/add-cocoa-beta branch December 5, 2024 18:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants