feat: allow retrieving the current user of a scope #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
==========================================
+ Coverage 72.79% 73.25% +0.45%
==========================================
Files 66 66
Lines 7804 7926 +122
==========================================
+ Hits 5681 5806 +125
+ Misses 2123 2120 -3 |
|
CI failures are addressed in #716. |
Swatinem
approved these changes
Dec 19, 2024
github-merge-queue bot
pushed a commit
to firezone/firezone
that referenced
this pull request
Dec 20, 2024
Previously, we needed to track our own user state in order to set the whole thing in Sentry. That was necessary because Sentry didn't allow us to _retrieve_ the current user of the scope but always required the full user to be set. This was changed getsentry/sentry-rust#715, which allows us to remove some of that code and hopefully mitigating any sort of lingering state when it comes to telemetry sessions.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our application, not all information of the current user is known immediately upfront. The user ID is loaded directly on startup but the account that they log in to is only known later.
Currently, we have to separately track this information because we always have to set the entire user at once. To avoid this, this PR adds a
usergetter to get the current user from the scope. This solves our use-case because we can get the current user and produce a new one that has additional fields and set it again.Resolves: #706.