Skip to content

chore(react): Bump react & react-dom to version 16.14.0 #21534

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

chore(react): Bump react & react-dom to version 16.14.0 #21534

merged 1 commit into from
Oct 27, 2020

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Oct 22, 2020 •
edited
Loading

Bump react & react-dom to version 16.14.0

We are currently experiencing the same error reported here facebook/react#20031 and we will have to wait for a solution

@priscilawebdev priscilawebdev requested a review from a team as a code owner October 22, 2020 13:35
@priscilawebdev priscilawebdev removed the request for review from a team October 22, 2020 13:39
@github-actions
Copy link
Contributor

size-limit report

Path Size
public/app.js 240.51 KB (0%)
public/vendor.js 445.71 KB (-0.1% 🔽)

@billyvg
Copy link
Member

billyvg commented Oct 22, 2020

@priscilawebdev We can still upgrade to 16.14, we just can't rely on JSX being in context w/o importing React

@priscilawebdev
Copy link
Member Author

@billyvg you are right...everything works out of the box (if we don't remove the React import)

@priscilawebdev priscilawebdev requested a review from a team October 23, 2020 07:10
markstory
markstory approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first step. We can revisit the import drop when there is a solution for key in prop spreading.

@morlay
Copy link

morlay commented Oct 26, 2020 •
edited
Loading

Waiting for emotion-js/emotion#1970 merged, before switching to jsx-runtime.

or putting key prop before {...spread}

@priscilawebdev
Copy link
Member Author

Thanks for the heads-up @morlay :) I prefer to wait until the PR emotion-js/emotion#1970 is merged

@priscilawebdev priscilawebdev merged commit 9ed4b12 into master Oct 27, 2020
@priscilawebdev priscilawebdev deleted the chore/bump-react-to-16-14-0 branch October 27, 2020 08:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@markstory markstory markstory approved these changes

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@priscilawebdev @billyvg @morlay @markstory