Skip to content

chore(stacktrace): Make source map tooltip aligned #82016

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

MichaelSun48
Copy link
Member

this has annoyed me since forever

before:

image

after: (notice the tooltip is aligned with the stack trace file path now)

image

(This changes applies to both the old and new issue details pages)

@MichaelSun48 MichaelSun48 requested a review from a team December 12, 2024 18:13
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 12, 2024
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@MichaelSun48 MichaelSun48 merged commit 29fcc33 into master Dec 13, 2024
43 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/alignStacktraceLine branch December 13, 2024 19:11
@scttcper scttcper added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Dec 16, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 57dbdf8

getsentry-bot added a commit that referenced this pull request Dec 16, 2024
This reverts commit 29fcc33.

Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
@scttcper
Copy link
Member

reverting because of #82124

evanh pushed a commit that referenced this pull request Dec 17, 2024
this has annoyed me since forever

before: 


![image](https://github.com/user-attachments/assets/33733ee9-646b-4949-a18d-6a29e16b6028)


after: (notice the tooltip is aligned with the stack trace file path
now)


![image](https://github.com/user-attachments/assets/2e199d45-1126-4878-84ea-41e11d50130c)


(This changes applies to both the old and new issue details pages)
evanh pushed a commit that referenced this pull request Dec 17, 2024
This reverts commit 29fcc33.

Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants