Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(profiling): Alphabetical and left heavy modes for continuous prof… #83249

Merged

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Jan 10, 2025

…iles

Alphabetical sort for continuous profiles was completely broken and left heavy mode wasn't properly merging frames.

Fixes JAVASCRIPT-2VSY

…iles

Alphabetical sort for continuous profiles was completely broken and left heavy
mode wasn't properly merging frames.
@Zylphrex Zylphrex requested a review from a team as a code owner January 10, 2025 19:21
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #83249   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files        9470     9470           
  Lines      537101   537054   -47     
  Branches    21142    21128   -14     
=======================================
- Hits       470296   470269   -27     
+ Misses      66447    66427   -20     
  Partials      358      358           

@Zylphrex Zylphrex merged commit 418a4c9 into master Jan 10, 2025
44 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/alphabetical-and-left-heavy-for-continuous-profiles branch January 10, 2025 21:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants