Skip to content

feat(new-trace-issues): Updating designs for trace preview in issue details #83430

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2025
Merged

feat(new-trace-issues): Updating designs for trace preview in issue details #83430

merged 3 commits into from
Jan 14, 2025

Conversation

Abdkhan14
Copy link
Contributor

  • Added 'View Full Trace' action
  • Made full waterfall clickable, removed darkened bg effect
  • Updated title
Screenshot 2025-01-14 at 3 20 20 PM

@Abdkhan14 Abdkhan14 requested a review from a team as a code owner January 14, 2025 20:21
@Abdkhan14 Abdkhan14 requested review from a team and doralchan January 14, 2025 20:21
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
8531 2 8529 2
View the top 2 failed tests by shortest run time 
EventTraceView still renders trace link for performance issues
Stack Traces | 1.03s run time 
Error: Unable to find an element with the text: Trace. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../interfaces/performance/eventTraceView.spec.tsx:164:46)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
EventTraceView does not render the trace preview if it has no transactions
Stack Traces | 1.08s run time 
Error: Unable to find an element with the text: Trace. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../interfaces/performance/eventTraceView.spec.tsx:202:46)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

scttcper
scttcper approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Abdkhan14 Abdkhan14 merged commit 4c54823 into master Jan 14, 2025
43 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace_preview_issues branch January 14, 2025 21:23
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@Abdkhan14 @andrewshie-sentry
feat(new-trace-issues): Updating designs for trace preview in issue d…
a864884 
…etails (#83430)

- Added 'View Full Trace' action
- Made full waterfall clickable, removed darkened bg effect 
- Updated title
<img width="881" alt="Screenshot 2025-01-14 at 3 20 20 PM"
src="https://github.com/user-attachments/assets/2690e9d7-f620-4304-8438-bde5a51c056a"
/>

---------

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@scttcper scttcper scttcper approved these changes

@doralchan doralchan Awaiting requested review from doralchan

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdkhan14 @scttcper