Skip to content

feat(symx): Add os as a tag #83504

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat(symx): Add os as a tag #83504

merged 1 commit into from
Jan 15, 2025

Conversation

loewenheim
Copy link
Contributor

Filtering by OS would be nice. Cardinality-wise this is no problem since we are only interested in a list of 4 values.

This also adds the project ID to the context so we can more easily find the event if we need to.

Filtering by OS would be nice. Cardinality-wise
this is no problem since we are only interested
in a list of 4 values.

This also adds the project ID to the context so
we can more easily find the event if we need to.
@loewenheim loewenheim requested a review from a team as a code owner January 15, 2025 14:39
@loewenheim loewenheim self-assigned this Jan 15, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 15, 2025
@loewenheim loewenheim enabled auto-merge (squash) January 15, 2025 14:47
@loewenheim loewenheim merged commit ba96065 into master Jan 15, 2025
50 checks passed
@loewenheim loewenheim deleted the symx/os-tag branch January 15, 2025 15:08
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/lang/native/processing.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #83504      +/-   ##
==========================================
- Coverage   87.53%   87.52%   -0.01%     
==========================================
  Files        9406     9406              
  Lines      537314   537315       +1     
  Branches    21156    21156              
==========================================
- Hits       470317   470306      -11     
- Misses      66652    66664      +12     
  Partials      345      345              

andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
Filtering by OS would be nice. Cardinality-wise this is no problem since
we are only interested in a list of 4 values.

This also adds the project ID to the context so we can more easily find
the event if we need to.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants