feat(aci): automation creation scaffolding #89233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ameliahsu
force-pushed
the
mia/aci/new-settings
branch
from
7484c94 to
e0183ce
Compare
ameliahsu
force-pushed
the
mia/aci/new-settings
branch
from
e0183ce to
fdb1e6d
Compare
ameliahsu
force-pushed
the
mia/aci/new-settings
branch
from
fdb1e6d to
27bb72e
Compare
ryan953
reviewed
Apr 15, 2025
ryan953
reviewed
Apr 15, 2025
scttcper
reviewed
Apr 15, 2025
scttcper
reviewed
Apr 15, 2025
scttcper
reviewed
Apr 15, 2025
scttcper
reviewed
Apr 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89233 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 10162 10162
Lines 573696 573695 -1
Branches 22597 22597
=======================================
Hits 503305 503305
+ Misses 69957 69956 -1
Partials 434 434 |
scttcper
reviewed
Apr 15, 2025
scttcper
reviewed
Apr 15, 2025
natemoo-re
reviewed
Apr 16, 2025
natemoo-re
reviewed
Apr 16, 2025
static/app/views/automations/components/automationBuilderContext.tsx
Outdated
Show resolved
Hide resolved
natemoo-re
approved these changes
Apr 17, 2025
static/app/views/automations/components/actionFilters/ageComparison.tsx
Outdated
Show resolved
Hide resolved
static/app/views/automations/components/actionFilters/ageComparison.tsx
Outdated
Show resolved
Hide resolved
static/app/views/automations/components/actionFilters/issueOccurrences.tsx
Show resolved
Hide resolved
static/app/views/automations/components/automationBuilderContext.tsx
Outdated
Show resolved
Hide resolved
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
scaffolding for step 2 of automation creation at `/new-settings` this introduces a new npm dependency, [`flattie`](https://github.com/lukeed/flattie), in order to easily sync the automation form data to the automation builder state. - **the problem:** the automation builder includes lots of nesting (data condition groups >> data conditions (which can also have nested data condition groups!) >> comparison input fields). see types [here](https://github.com/getsentry/sentry/blob/c980de65aed1c79be7f3d08b81f1eeef2d89382d/static/app/types/workflowEngine/dataConditions.tsx#L65-L79) - **alternative solution without these packages:** we would have to manually iterate through the automation details in order to populate the form model's data. - **preferred solution with these packages:** `flattie` is used to take an automation details result from the API and flatten it for the form model to understand. this utility is very small (`203B`), and there would be very little benefit in maintaining a version ourselves. view preview [here](https://sentry-4xprfca9b.sentry.dev/issues/automations/new/settings) https://github.com/user-attachments/assets/b1cbcea9-8e4e-4865-a404-1812954dd1b8
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scaffolding for step 2 of automation creation at
/new-settingsthis introduces a new npm dependency,
flattie, in order to easily sync the automation form data to the automation builder state.flattieis used to take an automation details result from the API and flatten it for the form model to understand. this utility is very small (203B), and there would be very little benefit in maintaining a version ourselves.view preview here
Screen.Recording.2025-04-14.at.5.54.59.PM.mov