Skip to content

feat(eap): add span.name field alias #89254

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

feat(eap): add span.name field alias #89254

merged 1 commit into from
Apr 11, 2025

Conversation

mjq
Copy link
Member

@mjq mjq commented Apr 10, 2025

Sentry's new span schema is aligning with OTel, introducing name as the top level field by which a span's operation is identified. This effectively replaces op in Sentry's current data model.

Add span.name as a secondary alias for the underlying sentry.op field.

I considered trying to put this field behind a feature flag, but the blast radius is pretty large since this field is currently a constant that is transformed into several other constants, all of which would have to become dynamic. Adding it as a secondary alias means it shouldn't yet show up anywhere unless a user explicity tries to use it. We might start conditionally using it in the frontend behind a feature flag.

Eventually, span.op will become the secondary alias, for backwards compatibility.

Sentry's new span schema is aligning with OTel, introducing `name` as the top
level field by which a span's operation is identified. This effectively
replaces `op` in Sentry's current data model.

Add `span.name` as a secondary alias for the underlying `sentry.op` field.

I considered trying to put this field behind a feature flag, but the blast
radius is pretty large since this field is currently a constant that is
transformed into several other constants, all of which would have to become
dynamic. Adding it as a secondary alias means it shouldn't yet show up anywhere
unless a user explicity tries to use it. We might start conditionally using it
in the frontend behind a feature flag.

Eventually, `span.op` will become the secondary alias, for backwards
compatibility.
@mjq mjq requested a review from a team as a code owner April 10, 2025 05:11
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 10, 2025
@mjq mjq merged commit 0c743bb into master Apr 11, 2025
61 checks passed
@mjq mjq deleted the mjq-add-span-name-field branch April 11, 2025 01:52
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
Sentry's new span schema is aligning with OTel, introducing `name` as
the top level field by which a span's operation is identified. This
effectively replaces `op` in Sentry's current data model.

Add `span.name` as a secondary alias for the underlying `sentry.op`
field.

I considered trying to put this field behind a feature flag, but the
blast radius is pretty large since this field is currently a constant
that is transformed into several other constants, all of which would
have to become dynamic. Adding it as a secondary alias means it
shouldn't yet show up anywhere unless a user explicity tries to use it.
We might start conditionally using it in the frontend behind a feature
flag.

Eventually, `span.op` will become the secondary alias, for backwards
compatibility.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants