chore(perf-issues): Add a flag and check it to allow customer to disable detectors #91734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
approved these changes
May 15, 2025
mrduncan
approved these changes
May 15, 2025
I agree about the clean up, there are a lot of magic strings around here and places you have to update when extending a detector and it's pretty easy to get wrong. |
…or-per-project-to-be-user-facing
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91734 +/- ##
==========================================
- Coverage 87.61% 87.61% -0.01%
==========================================
Files 10335 10335
Lines 586491 586479 -12
Branches 22550 22548 -2
==========================================
- Hits 513846 513829 -17
- Misses 72199 72204 +5
Partials 446 446 |
leeandher
deleted the
leander/id-621-expose-disableenable-detector-per-project-to-be-user-facing
branch
leeandher
added a commit
that referenced
this pull request
May 16, 2025
Add tests for feature flag check implemented in #91734, forgot them there
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
Add tests for feature flag check implemented in #91734, forgot them there
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be overridden by detector work later on, but expose it now so customers can understand how it might work (and disable any detectors without support tickets)