Skip to content

feat(source-maps): Do not render source maps wizard if platform is react native #91860

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

priscilawebdev
Copy link
Member

If the platform is React Native, we shouldn’t guide users to run the Sentry Wizard with the sourcemaps option, as that workflow doesn’t apply to React Native. Source maps are generated and uploaded differently during the app’s build process. This PR updates the messaging to reflect that and instead directs users to the appropriate documentation.

when we show multiple tabs
Screenshot 2025-05-19 at 11 43 47

when we show only releases:
Screenshot 2025-05-19 at 11 38 23

when we show only debug ids
Screenshot 2025-05-19 at 11 41 52

This is a follow-up of #87702
contributes to TET-363

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 19, 2025
@priscilawebdev priscilawebdev marked this pull request as ready for review May 19, 2025 11:26
@priscilawebdev priscilawebdev requested a review from a team as a code owner May 19, 2025 11:26
@priscilawebdev priscilawebdev requested review from a team and krystofwoldrich May 19, 2025 11:26
Comment on lines +683 to +687
{
link: sourceMapsDocLinks.debugIds ? (
<ExternalLink href={sourceMapsDocLinks.debugIds} />
) : undefined,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is not used at the moment, I assume this needs https://docs.sentry.io/platforms/javascript/sourcemaps/troubleshooting_js/debug-ids/ to be available also in the RN Docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the Debug IDs page for RN here:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this link is not available for react native. Great that we will have a doc soon 👏

Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the improvement.

I left one non blocking comment.

@priscilawebdev priscilawebdev merged commit 53590a7 into master May 21, 2025
42 checks passed
@priscilawebdev priscilawebdev deleted the priscila/feat/source-maps/update-copies-part-1 branch May 21, 2025 07:53
andrewshie-sentry pushed a commit that referenced this pull request Jun 2, 2025
…act native (#91860)

If the platform is React Native, we shouldn’t guide users to run the
Sentry Wizard with the sourcemaps option, as that workflow doesn’t apply
to React Native. This PR updates the messaging to reflect
that and instead directs users to the appropriate documentation.

contributes to TET-363
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants