Skip to content

ref: create project_id index for organizationonboardingtask #91918

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ remote_subscriptions: 0003_drop_remote_subscription

replays: 0005_drop_replay_index

sentry: 0903_missing_indexes_in_state
sentry: 0904_onboarding_task_project_id_idx

social_auth: 0002_default_auto_field

Expand Down
38 changes: 38 additions & 0 deletions src/sentry/migrations/0904_onboarding_task_project_id_idx.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Generated by Django 5.2.1 on 2025-05-19 22:18

from sentry.new_migrations.migrations import CheckedMigration
from sentry.new_migrations.monkey.special import SafeRunSQL


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production.
# This should only be used for operations where it's safe to run the migration after your
# code has deployed. So this should not be used for most operations that alter the schema
# of a table.
# Here are some things that make sense to mark as post deployment:
# - Large data migrations. Typically we want these to be run manually so that they can be
# monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# run this outside deployments so that we don't block them. Note that while adding an index
# is a schema change, it's completely safe to run the operation after the code has deployed.
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment

is_post_deployment = True

dependencies = [
("sentry", "0903_missing_indexes_in_state"),
]

operations = [
SafeRunSQL(
'CREATE INDEX CONCURRENTLY "sentry_organizationonboardingtask_project_id_bba0eae8" ON "sentry_organizationonboardingtask" ("project_id");',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what django thinks it should be called (forced by removing and re-adding db_index=...)

reverse_sql="",
hints={"tables": ["sentry_organizationonboardingtask"]},
),
SafeRunSQL(
# manually created in `us`
"DROP INDEX CONCURRENTLY IF EXISTS sentry_organizationonboardingtask_project_id_jtcunning;",
reverse_sql="",
hints={"tables": ["sentry_organizationonboardingtask"]},
),
]
Loading