Skip to content

chore(sdk): Use add_full_stack by default #91939

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

chore(sdk): Use add_full_stack by default #91939

merged 3 commits into from
May 21, 2025

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented May 20, 2025

The option has been enabled since the weekend (https://github.com/getsentry/sentry-options-automator/pull/3902).

This undoes some of what was added here.

@armenzg
chore(sdk): Use add_full_stack by default
ec74f25 
The option has been enabled since the weekend (getsentry/sentry-options-automator#3902).

This undoes some of what was added [here](#91062).
@armenzg armenzg requested a review from a team May 20, 2025 16:02
@armenzg armenzg self-assigned this May 20, 2025
@armenzg armenzg requested review from a team as code owners May 20, 2025 16:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 20, 2025
asottile-sentry
asottile-sentry reviewed May 20, 2025
View reviewed changes
@armenzg armenzg requested a review from asottile-sentry May 20, 2025 16:14
asottile-sentry
asottile-sentry approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov Codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157237 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #91939      +/-   ##
==========================================
- Coverage   87.62%   87.62%   -0.01%     
==========================================
  Files       10355    10356       +1     
  Lines      587350   587366      +16     
  Branches    22586    22586              
==========================================
+ Hits       514650   514662      +12     
- Misses      72273    72277       +4     
  Partials      427      427

@armenzg armenzg merged commit 56085f8 into master May 21, 2025
60 checks passed
@armenzg armenzg deleted the remove/feature/armenzg branch May 21, 2025 12:31
andrewshie-sentry pushed a commit that referenced this pull request Jun 2, 2025
@armenzg @andrewshie-sentry
chore(sdk): Use add_full_stack by default (#91939)
2de1b43 
The option has been enabled since the weekend
(getsentry/sentry-options-automator#3902).

This undoes some of what was added
[here](#91062).
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@cleptric cleptric cleptric approved these changes

@asottile-sentry asottile-sentry asottile-sentry approved these changes

Assignees

@armenzg armenzg

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armenzg @cleptric @asottile-sentry