fix(symbolicator): check source credentials and not the credential token #92024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
oioki
approved these changes
May 21, 2025
Codecov ReportAttention: Patch coverage is
|
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/sentry/lang/native/sources.py | 0.00% | 1 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## master #92024 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 10361 10361
Lines 587535 587535
Branches 22594 22594
=======================================
+ Hits 514863 514868 +5
+ Misses 72251 72246 -5
Partials 421 421 
loewenheim
approved these changes
May 21, 2025
antonpirker
pushed a commit
that referenced
this pull request
May 21, 2025
…ken (#92024) This PR fixes a bug where it would always report that no token can be obtained. The reason is that no refresh is being performed on the `source_credentials`, so it does not have a `token` property yet and the check will always return `False`.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
…ken (#92024) This PR fixes a bug where it would always report that no token can be obtained. The reason is that no refresh is being performed on the `source_credentials`, so it does not have a `token` property yet and the check will always return `False`.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where it would always report that no token can be obtained.
The reason is that no refresh is being performed on the
source_credentials, so it does not have atokenproperty yet and the check will always returnFalse.