-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Mobile SDK overhead measurement #5
Labels
Comments
4 tasks
This was referenced Aug 11, 2022
8 tasks
philipphofmann
pushed a commit
to getsentry/sentry-cocoa
that referenced
this issue
Aug 31, 2022
See the overall issue at getsentry/team-mobile#5 and the sibling PR at sentry-java for the approach & some more details: getsentry/sentry-java#2171
@vaind would you mind updating this issue with the latest changes? |
The size analyses bit could be replaced by https://docs.emergetools.com/reference/get_analysis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
What we want to measure:
captureMessage
,captureException
,startTransaction
,addBreadcrumb
, performance profilingWhat do we measure against:
main
branch and store it somewhere (gcloud)main
branchmain
and post in the PR as a comment. See actionGeneral approach
The goal is to run benchmarking on Sauce labs and check what’s the overhead (e.g. of the SDK during App start).
We can break the build if the overhead is more than a magic number or a specific percentage.
Profiling benchmark in Java does that - they break the test if the overhead is more than 5%. They also break the build if the overhead exceeds an absolute threshold.
Related:
Tracking issues, PRs and the current status
Java
The recently added (profiling-related) in-app benchmarks are based on Espresso (see getsentry/sentry-java#2013 & getsentry/sentry-java#2077. There has been a discussion about using Macrobenchmark in the PR that introduced the benchmarks, with the result being inconclusive and going ahead with the in-app benchmarks for now but evaluate Macrobenchmark.
Additionally, there's been an experiment with Jetpack Macrobenchmark in GDP to measure app startup - getsentry/sentry-android-gradle-plugin#317
The text was updated successfully, but these errors were encountered: